Fix move tracking #816
Open
Fix move tracking #816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #816 +/- ##
==========================================
+ Coverage 83.38% 83.55% +0.17%
==========================================
Files 39 47 +8
Lines 3918 5754 +1836
==========================================
+ Hits 3267 4808 +1541
- Misses 651 946 +295 🚀 New features to boost your workflow:
|
cameronangliss
force-pushed
the
track-moves
branch
from
b3af5f3 to
994fdab
Compare
cameronangliss
force-pushed
the
track-moves
branch
from
c3963ee to
cd0d901
Compare
cameronangliss
force-pushed
the
track-moves
branch
3 times, most recently
from
cadfaae to
75a1287
Compare
cameronangliss
force-pushed
the
track-moves
branch
from
75a1287 to
6ec9aed
Compare
cameronangliss
force-pushed
the
track-moves
branch
from
efa2af8 to
92cd92f
Compare
cameronangliss
force-pushed
the
track-moves
branch
from
cbd08f6 to
9f88b7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved move tracking guided by strict integration tests, which now also validate the tracked battle state against the
"active"section of the request message we receive. I also remove the dead code ofEmptyMove, which is completely unused throughout poke-env.